Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filetree_create generate unified files #723

Conversation

ivarmu
Copy link
Contributor

@ivarmu ivarmu commented Nov 7, 2023

What does this PR do?

  • Add a new parameter for the filetree_create role that allows to export all the objects to single files, where each object type corresponds to a unique file that is containing all the objects of the given object type. This allows the new output files to be consumed both from the Ansible group_vars and the filetree_read role, increasing the flexibility for the end user.
  • Adds a playbook to convert the current output files (structured) to a flatten ones
  • Fixes some issues found in the output files

How should this be tested?

Manual tests during the implementation.

Is there a relevant Issue open for this?

N/A

Other Relevant info, PRs, etc

N/A

@ivarmu ivarmu changed the title Filetree create unified files filetree_create generate unified files Nov 7, 2023
@ivarmu ivarmu marked this pull request as draft November 8, 2023 14:29
@ivarmu ivarmu marked this pull request as ready for review November 8, 2023 14:35
Copy link
Collaborator

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like a very useful option for many users

Copy link
Collaborator

@sean-m-sullivan sean-m-sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks useful, wonder how we can extend this.

@sean-m-sullivan
Copy link
Collaborator

This needs updated, and it wont allow me to rebase

@sean-m-sullivan sean-m-sullivan merged commit ea99379 into redhat-cop:devel Nov 20, 2023
13 checks passed
@ivarmu ivarmu deleted the filetree_create_unified_files branch March 27, 2024 07:06
przemkalit pushed a commit to przemkalit/aap_configuration that referenced this pull request Nov 22, 2024
* playbook to convert from filetree_create to flat files. job_templates, teams and team_roles to direct flat output

* all the objects has been updated to let flatten output

* fix lintering issues

* fix missing version for awx in the ci_standalone. Add ansible-playbook example command line for filetree_create

* fix versions for awx in the ci_standalone and release

* updated README.md. Added ansible-playbook command example

* Fixed the wrong location for the new information.

* Fixed the wrong location for the new information. Fix lintering
przemkalit pushed a commit to przemkalit/aap_configuration that referenced this pull request Nov 22, 2024
* playbook to convert from filetree_create to flat files. job_templates, teams and team_roles to direct flat output

* all the objects has been updated to let flatten output

* fix lintering issues

* fix missing version for awx in the ci_standalone. Add ansible-playbook example command line for filetree_create

* fix versions for awx in the ci_standalone and release

* updated README.md. Added ansible-playbook command example

* Fixed the wrong location for the new information.

* Fixed the wrong location for the new information. Fix lintering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants